Issue 119358: Change the IA32 stack handler layout so that the handler address does...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119358: Change the IA32 stack handler layout so that the handler address does... (Closed)

Created:
11 years, 6 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change the IA32 stack handler layout so that the handler address does not point into the middle of the handler. Also remove top-of-stack caching from MacroAssembler::PushTryHandler. Committed: http://code.google.com/p/v8/source/detail?r=2128

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -52 lines)			Patch
M	src/frames.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	9 chunks	+35 lines, -36 lines	0 comments	Download
M	src/ia32/frames-ia32.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/ia32/virtual-frame-ia32.cc	View	1 chunk	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages