Make Array.sort safely generic on JSObject types. Fix bug 346 http://code.go...

Make Array.sort safely generic on JSObject types.  Fix bug 346 http://code.google.com/p/v8/issues/detail?id=346

Committed: http://code.google.com/p/v8/source/detail?r=2133

[William Hesse, 2009-06-09 14:52:25]

Test case from bug 346 will also be added to unit tests.

http://codereview.chromium.org/119357/diff/1/2
File src/objects.cc (right):

http://codereview.chromium.org/119357/diff/1/2#newcode6469
Line 6469: PropertyDetails no_details = 0;
Change to PropertyDetails(NONE, NORMAL)

[Mads Ager (chromium), 2009-06-09 16:03:31]

LGTM

[Lasse Reichstein, 2009-06-10 05:12:41]

http://codereview.chromium.org/119357/diff/1/3
File src/array.js (right):

http://codereview.chromium.org/119357/diff/1/3#newcode817
Line 817: delete obj[i];
For compatability with Safari, we should only delete if it doesn't expose a
property of the prototype.
Perhaps add a test
 if (!(i in obj.__proto__)) { delete obj[i]; }
(Unless we ignore compatability in the presence of accessors)

[William Hesse, 2009-06-10 11:15:06]

Regression test added.  Also fixed some comments and whitespace typos.

http://codereview.chromium.org/119357/diff/1/3
File src/array.js (right):

http://codereview.chromium.org/119357/diff/1/3#newcode817
Line 817: delete obj[i];
On 2009/06/10 05:12:41, Lasse Reichstein wrote:
> For compatability with Safari, we should only delete if it doesn't expose a
> property of the prototype.
> Perhaps add a test
>  if (!(i in obj.__proto__)) { delete obj[i]; }
> (Unless we ignore compatability in the presence of accessors)

Done.

http://codereview.chromium.org/119357/diff/1/2
File src/objects.cc (right):

http://codereview.chromium.org/119357/diff/1/2#newcode6469
Line 6469: PropertyDetails no_details = 0;
On 2009/06/09 14:52:25, William Hesse wrote:
> Change to PropertyDetails(NONE, NORMAL)

Done.

[Mads Ager (chromium), 2009-06-10 11:23:46]

LGTM