Issue 119356: Add watchlist rules for src/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119356: Add watchlist rules for src/ (Closed)

Created:
11 years, 6 months ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add watchlist rules for src/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18208

Patch Set 7 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
	A	WATCHLISTS	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

http://codereview.chromium.org/119356/diff/1003/6 File watchlist_rules.py (right): http://codereview.chromium.org/119356/diff/1003/6#newcode16 Line 16: 'filepath': '\.mm$|_mac\.(cc|h)$', E.g. also want '/cocoa/' (and possibly ...

11 years, 6 months ago (2009-06-09 17:36:00 UTC) #1

Nirnimesh

On 2009/06/09 17:36:00, John Grabowski wrote: > http://codereview.chromium.org/119356/diff/1003/6 > File watchlist_rules.py (right): > > http://codereview.chromium.org/119356/diff/1003/6#newcode16 ...

11 years, 6 months ago (2009-06-09 22:53:10 UTC) #2

M-A Ruel

11 years, 6 months ago (2009-06-11 21:13:38 UTC) #5

No need to add as reviewer. lgtm

No need to make the file executable either BTW.

Expand Messages | Collapse Messages

Issue 119356: Add watchlist rules for src/ (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Messages