Issue 119353: Add instanceof stub for ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119353: Add instanceof stub for ARM. (Closed)

Created:
11 years, 6 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add instanceof stub for ARM. Committed: http://code.google.com/p/v8/source/detail?r=2132

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -97 lines)			Patch
M	src/arm/builtins-arm.cc	View	1 2 3	5 chunks	+5 lines, -15 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1 2 3	10 chunks	+77 lines, -38 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	1 2 3	5 chunks	+7 lines, -17 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 2 3	1 chunk	+32 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 2 3	1 chunk	+56 lines, -0 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1 2 3	4 chunks	+4 lines, -12 lines	0 comments	Download
M	src/arm/virtual-frame-arm.cc	View	1 2 3	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/codegen.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 6 months ago (2009-06-09 14:26:07 UTC) #2

LGTM.

http://codereview.chromium.org/119353/diff/1012/1016
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/119353/diff/1012/1016#newcode5061
Line 5061: __ CmpObjectType(r4, FIRST_JS_OBJECT_TYPE, r5);
I might be inclined to change CmpObjectType to CompareObjectType, but maybe
that's just me.

http://codereview.chromium.org/119353/diff/1012/1016#newcode5085
Line 5085: __ nop();
If this nop really needed, I think it deserves a comment.

http://codereview.chromium.org/119353/diff/1012/1016#newcode5088
Line 5088: // Slow-case.  We set the flags to ne to indicate the stub did not
find the
Comment out of date? No flags setting...

http://codereview.chromium.org/119353/diff/1012/1017
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/119353/diff/1012/1017#newcode763
Line 763: ldr(result, FieldMemOperand(function, HeapObject::kMapOffset));
This looks like CmpObjectType.

Expand Messages | Collapse Messages