Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 119335: Linux: refactor zygote support (Closed)

Created:
11 years, 6 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
dank
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: refactor zygote support http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser.

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : ... #

Patch Set 4 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+722 lines, -1214 lines) Patch
M base/base.gyp View 1 4 chunks +3 lines, -6 lines 0 comments Download
M base/command_line.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/command_line.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M base/file_util_posix.cc View 2 chunks +2 lines, -14 lines 0 comments Download
A base/global_descriptors_posix.h View 1 2 1 chunk +63 lines, -0 lines 0 comments Download
A base/global_descriptors_posix.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M base/logging.cc View 1 3 chunks +0 lines, -18 lines 0 comments Download
M base/process_util.h View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M base/process_util_linux.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download
M base/reserved_file_descriptors.h View 1 chunk +0 lines, -36 lines 0 comments Download
A base/unix_domain_socket_posix.h View 1 chunk +22 lines, -0 lines 0 comments Download
A base/unix_domain_socket_posix.cc View 2 1 chunk +98 lines, -0 lines 0 comments Download
M base/zygote_manager.h View 1 1 chunk +0 lines, -143 lines 0 comments Download
M base/zygote_manager.cc View 1 1 chunk +0 lines, -832 lines 0 comments Download
M chrome/app/breakpad_linux.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 2 7 chunks +22 lines, -15 lines 0 comments Download
M chrome/app/chrome_main_uitest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/plugin_process_host.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 9 chunks +52 lines, -23 lines 0 comments Download
A chrome/browser/zygote_host_linux.h View 2 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/zygote_host_linux.cc View 2 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/browser/zygote_main_linux.cc View 2 1 chunk +168 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/common/chrome_descriptors.h View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/ipc_channel.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/common/ipc_channel_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/ipc_channel_posix.cc View 1 2 7 chunks +10 lines, -15 lines 0 comments Download
M chrome/common/ipc_channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/ipc_channel_proxy.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/ipc_tests.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M chrome/common/process_watcher_posix.cc View 2 chunks +1 line, -14 lines 0 comments Download
M chrome/plugin/plugin_main.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/chrome_process_util.cc View 4 chunks +35 lines, -41 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
agl
Obviously I need to merge this with your patch when it lands.
11 years, 6 months ago (2009-06-08 23:37:27 UTC) #1
agl
11 years, 6 months ago (2009-06-08 23:37:39 UTC) #2
agl
11 years, 6 months ago (2009-06-09 22:09:52 UTC) #3
Ok, ready for review again...

Powered by Google App Engine
This is Rietveld 408576698