Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 119334: Merge r17891.... (Closed)

Created:
11 years, 6 months ago by Mark Larson
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Merge r17891. Fix regression where hitting enter in the Omnibox would ignore recent editing. Sadly, the only way I could find to fix this was a latest_result() accessor, because when the user hits enter, we really do need to use the very latest results. This just highlights how more of this stuff should move to the AutocompleteController. BUG=13428 TEST=Type "food.c" and wait for the popup to stabilize. Then _very_ quickly type "om" and hit enter. You should navigate to food.com instead of searching for "food.c". TBR=pkasting Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M chrome/browser/autocomplete/autocomplete.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_model.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_model.cc View 1 chunk +21 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Larson
11 years, 6 months ago (2009-06-08 23:28:15 UTC) #1
Peter Kasting
11 years, 6 months ago (2009-06-08 23:33:49 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698