Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 119331: Support Jaunty by dropping package xcb-xlib0 (Closed)

Created:
11 years, 6 months ago by dank
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Support Jaunty by dropping package xcb-xlib0. Support (our local flavor of) hardy by dropping package sun-java6-fonts (which is broken there). Add optional support for gold. (It would be better to not replace the system linker, but it's reversible, and works well unless you need to build wine or valgrind.) BUG=13457 TEST=verify that this installs a working chrome dev env on clean hardy and jaunty Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18175

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -5 lines) Patch
M build/install-build-deps.sh View 1 5 chunks +77 lines, -5 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
dank
How's this look?
11 years, 6 months ago (2009-06-08 23:05:18 UTC) #1
wtc
I'm not the right person to review this script, but it LGTM. Two nits about ...
11 years, 6 months ago (2009-06-08 23:14:21 UTC) #2
dank
Whoops, evan's out of the office, can you review this? wtc requested it and says ...
11 years, 6 months ago (2009-06-10 15:10:22 UTC) #3
agl
11 years, 6 months ago (2009-06-10 15:44:12 UTC) #4
LGTM

http://codereview.chromium.org/119331/diff/5/6
File build/install-build-deps.sh (right):

http://codereview.chromium.org/119331/diff/5/6#newcode177
Line 177: echo -n "Install gold from binutils-2.19.1 as ld?  It's 5x faster
(y/N) "
echo "WARNING: this is replace your system wide linker!"

Powered by Google App Engine
This is Rietveld 408576698