Issue 119308: Evan lied to me. The stub script needed to use "$@" and not "$*".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119308: Evan lied to me. The stub script needed to use "$@" and not "$*". (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
kuchhal, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Evan lied to me. The stub script needed to use "$@" and not "$*". Otherwise, all the parameters are coagulated into a single one. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17968

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	git-cl	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	git-try	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

kuchhal

11 years, 6 months ago (2009-06-09 17:32:46 UTC) #2

lgtm.

Can you please commit this? To use "dcommit -f" I ended up removing the part of
tree status check.