Issue 119302: Change IA32's CodeGenerator::GenerateFastCharCodeAt to eagerly...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119302: Change IA32's CodeGenerator::GenerateFastCharCodeAt to eagerly... (Closed)

Created:
11 years, 6 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change IA32's CodeGenerator::GenerateFastCharCodeAt to eagerly allocate and spill registers, so that the register reference counts and virtual frame are unchanged in the main body. This eliminates a few sites of magic branching or binding of JumpTarget with arguments. Committed: http://code.google.com/p/v8/source/detail?r=2126

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -86 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View	1 2	2 chunks	+109 lines, -86 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

11 years, 6 months ago (2009-06-08 12:38:42 UTC) #2

LGTM

http://codereview.chromium.org/119302/diff/1002/1003
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/119302/diff/1002/1003#newcode4646
Line 4646: if ((object.is_register() && object.reg().is(ecx)) ||
This would actually be the same number of lines if you handled the two cases in
separate ifs.  And more readable IMHO.

Expand Messages | Collapse Messages