Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 119289: Enable zygote manager by default. (Closed)

Created:
11 years, 6 months ago by dank
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enable zygote manager by default. Fix broken recursion check. Make OpenFile warning less scary, indicate it's normal at start of ui tests. Make ui tests pass. Avoid generating extra code on Mac. BUG=11841 TEST=start the browser, then make chrome and all .pak files unreadable; or alternately, start an installed browser, and uninstall the browser while it's running. Then create a new tab and browse to two new sites. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17909

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -19 lines) Patch
M base/file_util_posix.cc View 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M base/logging.cc View 2 chunks +5 lines, -1 line 0 comments Download
M base/process_util.h View 2 chunks +9 lines, -0 lines 0 comments Download
M base/process_util_linux.cc View 2 chunks +45 lines, -1 line 0 comments Download
M base/process_util_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M base/zygote_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/zygote_manager.cc View 1 2 3 4 5 6 7 8 chunks +17 lines, -13 lines 0 comments Download
M chrome/test/chrome_process_util.cc View 1 chunk +21 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dank
11 years, 6 months ago (2009-06-08 22:49:04 UTC) #1
dank
OK, now it's ready for review. (Still waiting for try server results, but it passes ...
11 years, 6 months ago (2009-06-08 22:49:42 UTC) #2
agl
11 years, 6 months ago (2009-06-08 22:58:26 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698