Issue 119289: Enable zygote manager by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119289: Enable zygote manager by default. (Closed)

Created:
11 years, 6 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable zygote manager by default. Fix broken recursion check. Make OpenFile warning less scary, indicate it's normal at start of ui tests. Make ui tests pass. Avoid generating extra code on Mac. BUG=11841 TEST=start the browser, then make chrome and all .pak files unreadable; or alternately, start an installed browser, and uninstall the browser while it's running. Then create a new tab and browse to two new sites. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17909

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -19 lines)			Patch
M	base/file_util_posix.cc	View	3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	base/logging.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	base/process_util.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	base/process_util_linux.cc	View		2 chunks	+45 lines, -1 line	0 comments	Download
M	base/process_util_unittest.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	base/zygote_manager.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/zygote_manager.cc	View	1 2 3 4 5 6 7	8 chunks	+17 lines, -13 lines	0 comments	Download
M	chrome/test/chrome_process_util.cc	View		1 chunk	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dank

OK, now it's ready for review. (Still waiting for try server results, but it passes ...

11 years, 6 months ago (2009-06-08 22:49:42 UTC) #2

LGTM

Expand Messages | Collapse Messages