Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 119284: Use more sensible behavior in presubmit checks. (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Jói Sigurðsson
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use more sensible behavior in presubmit checks. It's less annoying to type Y than to have to rerun the scripts with --no_presubmit for certain checks. TEST=none BUG=none TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M presubmit_canned_checks.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/presubmit_unittest.py View 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
TBR
11 years, 6 months ago (2009-06-06 18:58:20 UTC) #1
Jói Sigurðsson
11 years, 6 months ago (2009-06-06 23:21:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698