Issue 119283: Always output 32bit integer values in header of CRX file....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119283: Always output 32bit integer values in header of CRX file.... (Closed)

Created:
11 years, 6 months ago by hamaji

Modified:
9 years, 5 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Always output 32bit integer values in header of CRX file. It seems that 'l' data type of Python's array uses long, which is 64bit integer in LP64 environemnts. This means that this script generates corrupt headers in LP64 environments such as AMD64. Let's just use 'i' data type for 32bit integer. http://docs.python.org/library/array.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17835

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/tools/extensions/chromium_extension.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hamaji

If you think we need to care about sizeof(int)!=4 environments such as ILP64, please let ...

11 years, 6 months ago (2009-06-06 15:20:37 UTC) #1

LGTM

good catch.  thanks!

Expand Messages | Collapse Messages