Issue 119271: Re-Retry. This is the change from hell....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119271: Re-Retry. This is the change from hell.... (Closed)

Created:
11 years, 6 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Re-Retry. This is the change from hell. Revert DCHECKs to what they used to be - turns out a bunch of stuff in the code depended on input.empty() == true. --- I believe the code (with your width() * bbp fix) is correct. The UMR errors occur when the source image contain alpha. I believe the issue comes from webkit glue image decoder, and the reason this only started triggering valgrind errors is that the old ones were masked by the change detailed in bug 12640 Also adds valgrind suppression for the new code. TBR=Nick BUG=12891, 12640 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17811

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -5 lines)			Patch
	M	base/gfx/png_encoder.cc	View		2 chunks	+34 lines, -5 lines	0 comments	Download
	M	tools/valgrind/suppressions_mac.txt	View		1 chunk	+10 lines, -0 lines	0 comments	Download