Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 119268: Add support for a .gclient_ignore which tells gclient to ignore versioning of... (Closed)

Created:
11 years, 6 months ago by awong
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add support for a .gclient_ignore which tells gclient to ignore versioning of a directory on a sync. Behavior is exactly like having a .git file except that it won't interfere with git functionality. An example where this comes up is if you have all of WebKit checked out in a git repository, and swap out src/third_party/WebKit to point to the git version. Since some of the subdirectories under WebKit (eg., src/third_party/WebKit/JavaScriptCore) are specified as separate dependencies, gclient will attempt to update them, but they won't have a .git directory .

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M gclient.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
awong
11 years, 6 months ago (2009-06-05 23:37:33 UTC) #1
M-A Ruel
You should use custom_deps instead ??
11 years, 6 months ago (2009-06-06 01:01:36 UTC) #2
awong
On 2009/06/06 01:01:36, Marc-Antoine Ruel wrote: > You should use custom_deps instead ?? So, adding ...
11 years, 6 months ago (2009-06-09 18:01:12 UTC) #3
awong
11 years, 6 months ago (2009-06-15 20:59:39 UTC) #4
On 2009/06/09 18:01:12, awong wrote:
> On 2009/06/06 01:01:36, Marc-Antoine Ruel wrote:
> > You should use custom_deps instead ??
> 
> So, adding a "some_directory": None into the custom_deps isn't supposed to
> delete the directory tree then?
> 
> Is this a bug you're working on, or should I take a stab at it?
> 
> Thanks,
> Albert

Closing in favor of a different fix.
http://codereview.chromium.org/125147

Powered by Google App Engine
This is Rietveld 408576698