Issue 119267: Linux: Import passwords from Firefox.

Issue 119267: Linux: Import passwords from Firefox. (Closed)

Created:
11 years, 6 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: Import passwords from Firefox. BUG=11191 TEST=Try importing password from Firefox on Linux and it should work (though they are not accessible in UI yet).

Patch Set 2 : use base/native_library #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -48 lines)			Patch
	M	chrome/browser/importer/firefox_importer_utils.h	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download
	M	chrome/browser/importer/firefox_importer_utils.cc	View	1	9 chunks	+51 lines, -43 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/119267/diff/1/2 File chrome/browser/importer/firefox_importer_utils.cc (right): http://codereview.chromium.org/119267/diff/1/2#newcode13 Line 13: #define GET_SYMBOL GetProcAddress I guess you should be ...

11 years, 6 months ago (2009-06-05 23:44:40 UTC) #2

kuchhal

I believe I have addressed all the comments from Evan but since he is out ...

11 years, 6 months ago (2009-06-08 23:31:31 UTC) #3

tony

LGTM, just a question. Fine to submit either way. http://codereview.chromium.org/119267/diff/1005/6 File chrome/browser/importer/firefox_importer_utils.cc (right): http://codereview.chromium.org/119267/diff/1005/6#newcode642 Line ...

11 years, 6 months ago (2009-06-09 00:00:51 UTC) #4

kuchhal

11 years, 6 months ago (2009-06-09 00:18:31 UTC) #5

Thanks for the review.

http://codereview.chromium.org/119267/diff/1005/6
File chrome/browser/importer/firefox_importer_utils.cc (right):

http://codereview.chromium.org/119267/diff/1005/6#newcode642
Line 642: #if !defined(OS_WIN) && !defined(OS_LINUX)
Yes returning empty string will work too but may be since we are not testing
this on MAC we want to make it clear that only Win & Linux are supported so far.

On 2009/06/09 00:00:51, tony wrote:
> Nit: Do we need this block or will the if (!nss3_dll_) work for us?  I guess
> having the NOTIMPLEMENTED() is useful.

Expand Messages | Collapse Messages