Issue 119265: Convert tcmalloc (and its modified libcmt) to building with gyp....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119265: Convert tcmalloc (and its modified libcmt) to building with gyp.... (Closed)

Created:
11 years, 6 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews_googlegroups.com, bradnelson

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Convert tcmalloc (and its modified libcmt) to building with gyp. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17828

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -12 lines)			Patch
M	build/all.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/app/chrome_dll.vcproj	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome.gyp	View		3 chunks	+2 lines, -7 lines	0 comments	Download
M	third_party/tcmalloc/prep_libc.sh	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A	third_party/tcmalloc/tcmalloc.gyp	View		1 chunk	+97 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

sgk

trybot fails on win with line ending issues in prep_libc.sh; will monitor when I submit

11 years, 6 months ago (2009-06-05 23:55:22 UTC) #1

lgtm