Issue 119256: Fix user scripts not getting initialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119256: Fix user scripts not getting initialized. (Closed)

Created:
11 years, 6 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Glen Murphy, Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix user scripts not getting initialized. BUG=13290, 13128 TEST=Add --enable-user-scripts to command line without --enable-extensions or --load-extension. Start Chrome, user scripts should work. Also run ui tests with --enable-extensions.

Patch Set 1 #

Patch Set 2 : Remove noise changes #

Patch Set 3 : Different fix, fix an unrelated bug that allows us to do only one scan #

Patch Set 4 : Fix unit tests #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -56 lines)			Patch
M	chrome/browser/extensions/extensions_service.cc	View	3	1 chunk	+6 lines, -14 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View		9 chunks	+17 lines, -35 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	3	1 chunk	+6 lines, -3 lines	0 comments	Download
M	chrome/test/testing_profile.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

+glen ... can whichever one of you sees this first review it? Ok, here's a ...

11 years, 6 months ago (2009-06-06 08:01:46 UTC) #2

LGTM, sorry for faffing it all up.

Expand Messages | Collapse Messages