Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 119252: Add InputApi.is_committing to be able to return a failure or notification, depending on the check. (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Jói Sigurðsson
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add InputApi.is_committing to be able to return a failure or notification, depending on the check. Add input_api.traceback, useful for dumping information. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17837

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : merged to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -38 lines) Patch
M presubmit_canned_checks.py View 1 1 chunk +8 lines, -2 lines 0 comments Download
M presubmit_support.py View 1 2 6 chunks +7 lines, -18 lines 0 comments Download
M tests/presubmit_unittest.py View 1 2 13 chunks +82 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
11 years, 6 months ago (2009-06-06 00:30:32 UTC) #1
Jói Sigurðsson
11 years, 6 months ago (2009-06-06 03:03:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698