breakpad/linux/exception_handler.cc - Issue 119249: Linux: Dumping a renderer can traverse an invalid pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: breakpad/linux/exception_handler.cc

Issue 119249: Linux: Dumping a renderer can traverse an invalid pointer. (Closed)

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: breakpad/linux/exception_handler.cc

diff --git a/breakpad/linux/exception_handler.cc b/breakpad/linux/exception_handler.cc

index ad7a11dda6a94f6e3aa537a4c34ccb4c4f4b6cef..a1c8379029610dcdb1608bea15849d4ad9fc9ffa 100644

--- a/breakpad/linux/exception_handler.cc

+++ b/breakpad/linux/exception_handler.cc

@@ -261,6 +261,8 @@ bool ExceptionHandler::HandleSignal(int sig, siginfo_t* info, void* uc) {

CrashContext context;

memcpy(&context.siginfo, info, sizeof(siginfo_t));

memcpy(&context.context, uc, sizeof(struct ucontext));

+ memcpy(&context.float_state, ((struct ucontext *)uc)->uc_mcontext.fpregs,

+ sizeof(context.float_state));

context.tid = sys_gettid();

if (crash_handler_ && crash_handler_(&context, sizeof(context),

« no previous file with comments | « breakpad/linux/exception_handler.h ('k') | breakpad/linux/minidump_writer.cc » ('j') | no next file with comments »