Issue 119209: Add example .croc file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119209: Add example .croc file. (Closed)

Created:
11 years, 6 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add example .croc file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17776

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+222 lines, -0 lines)			Patch
	A	tools/code_coverage/example.croc	View		1 chunk	+222 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

11 years, 6 months ago (2009-06-04 23:42:34 UTC) #2

LGTM

Only one small nit. It just occurred to me that you've been using 'key' :
'value' in croc, whereas the gyp files use: 'key': 'value' which is more in line
with the python style guide. Did we want consistency on that?

Expand Messages | Collapse Messages