Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: PRESUBMIT.py

Issue 119201: Add the tree check there instead of implementing it in the root PRESUBMIT.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | PRESUBMIT_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
===================================================================
--- PRESUBMIT.py (revision 17630)
+++ PRESUBMIT.py (working copy)
@@ -40,18 +40,30 @@
def CheckChangeOnUpload(input_api, output_api):
# TODO(maruel): max_cols is temporarily disabled. Reenable once the source
# tree is in better shape.
- return (LocalChecks(input_api, output_api, max_cols=0) +
- input_api.canned_checks.CheckChangeHasBugField(input_api, output_api) +
- input_api.canned_checks.CheckChangeHasTestField(input_api, output_api))
+ results = []
+ results.extend(LocalChecks(input_api, output_api, max_cols=0))
+ results.extend(input_api.canned_checks.CheckChangeHasBugField(input_api,
+ output_api))
+ results.extend(input_api.canned_checks.CheckChangeHasTestField(input_api,
+ output_api))
+ return results
def CheckChangeOnCommit(input_api, output_api):
+ results = []
# TODO(maruel): max_cols is temporarily disabled. Reenable once the source
# tree is in better shape.
- return (LocalChecks(input_api, output_api, max_cols=0) +
- input_api.canned_checks.CheckDoNotSubmit(input_api, output_api) +
- input_api.canned_checks.CheckChangeHasBugField(input_api, output_api) +
- input_api.canned_checks.CheckChangeHasTestField(input_api, output_api))
+ results.extend(LocalChecks(input_api, output_api, max_cols=0))
+ results.extend(input_api.canned_checks.CheckChangeHasBugField(input_api,
+ output_api))
+ results.extend(input_api.canned_checks.CheckChangeHasTestField(input_api,
+ output_api))
+ # Make sure the tree is 'open'.
+ results.extend(input_api.canned_checks.CheckTreeIsOpen(
+ input_api, output_api,
+ 'http://chromium-status.appspot.com/status', '0'
+ ))
+ return results
def LocalChecks(input_api, output_api, max_cols=80):
« no previous file with comments | « no previous file | PRESUBMIT_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698