Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: webkit/glue/webplugin_impl.cc

Issue 119200: Fixes a flash plugin hang caused by opening google finance ticker symbols in ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webplugin_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webplugin_impl.cc
===================================================================
--- webkit/glue/webplugin_impl.cc (revision 17917)
+++ webkit/glue/webplugin_impl.cc (working copy)
@@ -235,7 +235,6 @@
WebCore::Widget::setParent(view);
if (view) {
impl_->setFrameRect(frameRect());
- impl_->delegate_->FlushGeometryUpdates();
}
}
@@ -682,7 +681,8 @@
webkit_glue::FromIntRect(clip_rect));
// Initiate a download on the plugin url. This should be done for the
- // first update geometry sequence.
+ // first update geometry sequence. We need to ensure that the plugin
+ // receives the geometry update before it starts receiving data.
if (first_geometry_update_) {
first_geometry_update_ = false;
// An empty url corresponds to an EMBED tag with no src attribute.
@@ -1294,7 +1294,6 @@
// Force a geometry update to occur to ensure that the plugin becomes
// visible.
widget_->frameRectsChanged();
- delegate_->FlushGeometryUpdates();
// The plugin move sequences accumulated via DidMove are sent to the browser
// whenever the renderer paints. Force a paint here to ensure that changes
// to the plugin window are propagated to the browser.
« no previous file with comments | « webkit/glue/webplugin_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698