Fixes a flash plugin hang caused by opening google finance ticker symbols in ...

webkit/glue/webplugin_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "webkit/glue/webplugin_impl.h"
 
 #include "Cursor.h"
 #include "Document.h"
 #include "DocumentLoader.h"
@@ skipping 217 matching lines @@
 }
 
 // We override this function so that if the plugin is windowed, we can call
 // NPP_SetWindow at the first possible moment.  This ensures that NPP_SetWindow
 // is called before the manual load data is sent to a plugin.  If this order is
 // reversed, Flash won't load videos.
 void WebPluginContainer::setParent(WebCore::ScrollView* view) {
   WebCore::Widget::setParent(view);
   if (view) {
     impl_->setFrameRect(frameRect());
-    impl_->delegate_->FlushGeometryUpdates();
   }
 }
 
 void WebPluginContainer::windowCutoutRects(const WebCore::IntRect& bounds,
                                            WTF::Vector<WebCore::IntRect>*
                                            cutouts) const {
   impl_->windowCutoutRects(bounds, cutouts);
 }
 
 void WebPluginContainer::didReceiveResponse(
@@ skipping 426 matching lines @@
     move.visible = widget_->isVisible();
 
     webview->delegate()->DidMove(webview, move);
   }
 
   // Notify the plugin that its parameters have changed.
   delegate_->UpdateGeometry(webkit_glue::FromIntRect(window_rect),
                             webkit_glue::FromIntRect(clip_rect));
 
   // Initiate a download on the plugin url. This should be done for the
-  // first update geometry sequence.
+  // first update geometry sequence. We need to ensure that the plugin
+  // receives the geometry update before it starts receiving data.
   if (first_geometry_update_) {
     first_geometry_update_ = false;
     // An empty url corresponds to an EMBED tag with no src attribute.
     if (!load_manually_ && plugin_url_.is_valid()) {
       HandleURLRequestInternal("GET", false, NULL, 0, NULL, false, false,
                                plugin_url_.spec().c_str(), NULL, false,
                                false);
     }
   }
 }
@@ skipping 591 matching lines @@
     widget_ = NULL;
     // TODO(iyengar) Should we delete the current plugin instance here?
     return false;
   }
 
   mime_type_ = actual_mime_type;
   delegate_ = plugin_delegate;
   // Force a geometry update to occur to ensure that the plugin becomes
   // visible.
   widget_->frameRectsChanged();
-  delegate_->FlushGeometryUpdates();
   // The plugin move sequences accumulated via DidMove are sent to the browser
   // whenever the renderer paints. Force a paint here to ensure that changes
   // to the plugin window are propagated to the browser.
   widget_->invalidateRect(widget_->frameRect());
   return true;
 }
 
 void WebPluginImpl::ArrayToVector(int total_values, char** values,
                                   std::vector<std::string>* value_vector) {
   DCHECK(value_vector != NULL);
@@ skipping 37 matching lines @@
     client_index = clients_.erase(client_index);
     if (resource_client)
       resource_client->DidFail();
   }
 
   // This needs to be called now and not in the destructor since the
   // webframe_ might not be valid anymore.
   webframe_->set_plugin_delegate(NULL);
   webframe_ = NULL;
 }