Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 119189: Add two small features to the HttpCache for benchmarking/debugging.... (Closed)

Created:
11 years, 6 months ago by Mike Belshe
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add two small features to the HttpCache for benchmarking/debugging. The first exposes a method to close all idle sockets. This allows me to create benchmark tests in the app which can close connections before starting the test for better simulations. The second change is to expose cache modes for cache disabled and cache bypassed. DISABLE sets the LOAD_DISABLE_CACHE on every request; BYPASS sets the LOAD_BYPASS_CACHE on every request. TEST=http_cache_unittest.cc BUG=6754 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17720

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -11 lines) Patch
M net/http/http_cache.h View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M net/http/http_cache.cc View 1 2 3 4 4 chunks +28 lines, -10 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike Belshe
11 years, 6 months ago (2009-06-04 20:09:40 UTC) #1
rvargas (doing something else)
Looks good. Just a couple of comments. (and there are some lint warnings). http://codereview.chromium.org/119189/diff/12/13 File ...
11 years, 6 months ago (2009-06-04 21:08:20 UTC) #2
Mike Belshe
11 years, 6 months ago (2009-06-05 00:58:47 UTC) #3
nits submitted.

Powered by Google App Engine
This is Rietveld 408576698