Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 119183: Fix crash 12519: in views::DialogClientView::AcceptWindow()... (Closed)

Created:
11 years, 6 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix crash 12519: in views::DialogClientView::AcceptWindow() We don't have repro steps for this crash so this is a blind fix. But looking at the function that crashes and the history of this file I see: Ben's r11070 and r11047: Which add this check. Ben's r11132: Which removes this check (according to the comments it is a test to see if we can get away with it). It looks to me like the check would prevent the crash and since this is still crashing, I am proposing we re-add it. BUG=12519 TEST=We'll need to verify this by checking the crash dumps sent from the field. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17651

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M views/window/dialog_client_view.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Finnur
11 years, 6 months ago (2009-06-04 18:08:50 UTC) #1
Since this is only a few lines of code I though instead of discussing the
approach further in the bug I should just propose it on Rietveld. Probably
speeds things up. :)

Powered by Google App Engine
This is Rietveld 408576698