Fix the issue with layout tests....

Fix the issue with layout tests.

The problem was I incorrectly treated NULL result as failure to fetch
a property with a getter.  However, if getter returns zero, it is
manifested as NULL pointer (see added test case).

Good news: that gives another boost as before this CL if getter returned
0, I did another slow lookup.


Committed: http://code.google.com/p/v8/source/detail?r=2106

[Kasper Lund, 2009-06-04 12:29:26]

LGTM.

http://codereview.chromium.org/119172/diff/1/4
File src/objects.h (right):

http://codereview.chromium.org/119172/diff/1/4#newcode1551
Line 1551: bool GetPropertyWithInterceptorProper(JSObject* receiver,
It might be nice with a comment describing the return value and when result is
updated.

http://codereview.chromium.org/119172/diff/1/4#newcode1552
Line 1552: String* name,
Indentation is slightly off.

[antonm, 2009-06-04 13:40:41]

Tnx a lot, Kasper.

http://codereview.chromium.org/119172/diff/1/4
File src/objects.h (right):

http://codereview.chromium.org/119172/diff/1/4#newcode1551
Line 1551: bool GetPropertyWithInterceptorProper(JSObject* receiver,
On 2009/06/04 12:29:26, Kasper Lund wrote:
> It might be nice with a comment describing the return value and when result is
> updated.

Done.

http://codereview.chromium.org/119172/diff/1/4#newcode1552
Line 1552: String* name,
On 2009/06/04 12:29:26, Kasper Lund wrote:
> Indentation is slightly off.

Done.

[Mads Ager (chromium), 2009-06-04 19:06:19]

LGTM