Issue 119154: Add comments on magic number 0xbb. They are VK_OEM_PLUS. I guess the original...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119154: Add comments on magic number 0xbb. They are VK_OEM_PLUS. I guess the original... (Closed)

Created:
11 years, 6 months ago by hamaji

Modified:
9 years, 5 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Add comments on magic number 0xbb. They are VK_OEM_PLUS. I guess the original author of this code considered the case where VK_OEM_PLUS isn't defined. For example, it seems that 0xbb is VK_EQUAL for embeded environments and VK_OEM_PLUS is never defined. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18467

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_win.cc	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
	M	views/controls/textfield/native_textfield_win.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jcampan

LGTM http://codereview.chromium.org/119154/diff/7/8 File views/controls/textfield/native_textfield_win.cc (right): http://codereview.chromium.org/119154/diff/7/8#newcode440 Line 440: // We don't use VK_OEM_PLUS in case ...

11 years, 6 months ago (2009-06-15 22:49:49 UTC) #2

hamaji

11 years, 6 months ago (2009-06-15 23:05:39 UTC) #3

Thanks!

http://codereview.chromium.org/119154/diff/7/8
File views/controls/textfield/native_textfield_win.cc (right):

http://codereview.chromium.org/119154/diff/7/8#newcode440
Line 440: // We don't use VK_OEM_PLUS in case the macro isn't defined.
On 2009/06/15 22:49:49, jcampan wrote:
> Nit: could you add a short sentence explaining in which conditions VK_OEM_PLUS
> is defined or not?

Added.

Expand Messages | Collapse Messages