Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Issue 119125: Don't update our text from toolbar if the toolbar's text doesn't (Closed)

Created:
11 years, 6 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
Reviewers:
jeremy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Don't update our text from toolbar if the toolbar's text doesn't visibly differ from the model's text. In most cases, this doesn't come up, because focus is usually not in the field (so there wouldn't be local changes), but when opening NTP you can type between when the tab opens in the browser and when the renderer finishes loading it. In that case, the model and toolbar both have "" as the url text, so this case is hit. http://crbug.com/13109 TEST=Browse to www.google.com. Command-t for new tab and type http as fast as you can. Before this fix, you sometimes got "tp" or something of the sort.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed Jeremy's typo comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Scott Hess - ex-Googler
11 years, 6 months ago (2009-06-03 23:32:37 UTC) #1
jeremy
11 years, 6 months ago (2009-06-03 23:36:45 UTC) #2
LGTM

http://codereview.chromium.org/119125/diff/1/2
File chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (right):

http://codereview.chromium.org/119125/diff/1/2#newcode240
Line 240: // TODO(shess): This corrosponds to _win and _gtk, except those
corresponds

Powered by Google App Engine
This is Rietveld 408576698