Fix crash due to AutocompletePopup trying to draw the old results when they w...

chrome/browser/autocomplete/autocomplete.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete.h"
 
 #include <algorithm>
 
 #include "app/l10n_util.h"
 #include "base/basictypes.h"
@@ skipping 747 matching lines @@
   latest_result_.Validate();
 #endif
 
   if (is_synchronous_pass) {
     if (!max_delay_timer_.IsRunning()) {
       max_delay_timer_.Start(
           TimeDelta::FromMilliseconds(kResultUpdateMaxDelayMs),
           this, &AutocompleteController::CommitResult);
     }
 
-    result_.CopyFrom(latest_result_);
     NotificationService::current()->Notify(
         NotificationType::AUTOCOMPLETE_CONTROLLER_SYNCHRONOUS_MATCHES_AVAILABLE,
-        Source<AutocompleteController>(this), NotificationService::NoDetails());
+        Source<AutocompleteController>(this),
+        Details<const AutocompleteResult>(&latest_result_));
   }
 
   if (done_) {
     CommitResult();
   } else if (!update_pending_) {
     // Coalesce the results for the next kPopupCoalesceMs milliseconds.
     update_pending_ = true;
     coalesce_timer_.Stop();
     coalesce_timer_.Start(TimeDelta::FromMilliseconds(kResultCoalesceMs), this,
                           &AutocompleteController::CommitResult);
   }
 }
 
 void AutocompleteController::CommitResult() {
   // The max update interval timer either needs to be reset (if more updates
   // are to come) or stopped (when we're done with the query).  The coalesce
   // timer should always just be stopped.
   update_pending_ = false;
   coalesce_timer_.Stop();
   if (done_)
     max_delay_timer_.Stop();
   else
     max_delay_timer_.Reset();
 
   result_.CopyFrom(latest_result_);
   NotificationService::current()->Notify(
       NotificationType::AUTOCOMPLETE_CONTROLLER_RESULT_UPDATED,
-      Source<AutocompleteController>(this), NotificationService::NoDetails());
+      Source<AutocompleteController>(this),
+      Details<const AutocompleteResult>(&result_));
 }
 
 ACMatches AutocompleteController::GetMatchesNotInLatestResult(
     const AutocompleteProvider* provider) const {
   DCHECK(provider);
 
   // Determine the set of destination URLs.
   std::set<GURL> destination_urls;
   for (AutocompleteResult::const_iterator i(latest_result_.begin());
        i != latest_result_.end(); ++i)
@@ skipping 79 matching lines @@
     match.contents_class.push_back(
         ACMatchClassification(keyword_offset + input_.text().size(),
                               ACMatchClassification::NONE));
   }
   match.destination_url =
       HistoryUI::GetHistoryURLWithSearchText(input_.text());
   match.transition = PageTransition::AUTO_BOOKMARK;
   match.provider = history_contents_provider_;
   latest_result_.AddMatch(match);
 }