Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 119101: Fix ListRelevantPresubmitFiles(). (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Jói Sigurðsson
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix ListRelevantPresubmitFiles(). It was affected by the current directory! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17554

Patch Set 1 #

Patch Set 2 : Convert to functional programming! #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -127 lines) Patch
M presubmit_support.py View 1 4 chunks +23 lines, -23 lines 0 comments Download
M tests/presubmit_unittest.py View 1 2 37 chunks +175 lines, -104 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
It took me much more time than expected. :(
11 years, 6 months ago (2009-06-03 20:11:45 UTC) #1
Jói Sigurðsson
11 years, 6 months ago (2009-06-03 20:43:00 UTC) #2
LGTM

Very nice test update. Thanks for taking care of this.

Powered by Google App Engine
This is Rietveld 408576698