Add a few PyAuto tests for bookmarks....

Add a few PyAuto tests for bookmarks.

The first two tests are from rohitbm and the rest from krisrs.

testUnicodeStrings -- test bookmarks with unicode strings
testSizes -- test bookmarks with different sized strings
testAddingBookmarksToBarAndOther - add bookmarks to diff locations
testAddingFoldersToBarAndOther -- add bookmark groups to diff locations
testAddingFoldersWithChildrenToBarAndOther -- add bookmarks and groups to
                                              different locations


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42417

[Nirnimesh, 2010-03-23 19:50:25]

Adding a few bookmarks tests written by Rohit and Kris.

[John Grabowski, 2010-03-24 00:21:12]

http://codereview.chromium.org/1191002/diff/2001/3003
File chrome/test/data/bookmarks/long-and-short-names (right):

http://codereview.chromium.org/1191002/diff/2001/3003#newcode1
chrome/test/data/bookmarks/long-and-short-names:1: {
These files are eval'ed so we can easily add comments.
Document a new convention for data files; e.g. 

# Short_Name
# Short Description of what this is
# Used By: TestName in test_filename.py

http://codereview.chromium.org/1191002/diff/2001/3002
File chrome/test/data/bookmarks/urls_and_titles (right):

http://codereview.chromium.org/1191002/diff/2001/3002#newcode1
chrome/test/data/bookmarks/urls_and_titles:1: 
See my comments about other data file

http://codereview.chromium.org/1191002/diff/2001/3004
File chrome/test/functional/bookmarks.py (right):

http://codereview.chromium.org/1191002/diff/2001/3004#newcode117
chrome/test/functional/bookmarks.py:117: def _GetTestURLs(self, filename):
Have this function prefix the DataDir() for you.

http://codereview.chromium.org/1191002/diff/2001/3004#newcode120
chrome/test/functional/bookmarks.py:120: dictionary = eval(contents,
{'__builtins__': None}, None)
Add try around this to catch eval error; sometimes eval errors can be cryptic
and you want to be sure to print out the failed filename.

http://codereview.chromium.org/1191002/diff/2001/3001
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/1191002/diff/2001/3001#newcode134
chrome/test/pyautolib/pyauto.py:134: """Returns the path the data dir
chorme/test/data."""
chorme --> chrome

[Nirnimesh, 2010-03-24 00:49:45]

http://codereview.chromium.org/1191002/diff/2001/3003
File chrome/test/data/bookmarks/long-and-short-names (right):

http://codereview.chromium.org/1191002/diff/2001/3003#newcode1
chrome/test/data/bookmarks/long-and-short-names:1: {
On 2010/03/24 00:21:12, John Grabowski wrote:
> These files are eval'ed so we can easily add comments.
> Document a new convention for data files; e.g. 
> 
> # Short_Name
> # Short Description of what this is
> # Used By: TestName in test_filename.py
> 

Done.

http://codereview.chromium.org/1191002/diff/2001/3002
File chrome/test/data/bookmarks/urls_and_titles (right):

http://codereview.chromium.org/1191002/diff/2001/3002#newcode1
chrome/test/data/bookmarks/urls_and_titles:1: 
On 2010/03/24 00:21:12, John Grabowski wrote:
> See my comments about other data file

Done.

http://codereview.chromium.org/1191002/diff/2001/3004
File chrome/test/functional/bookmarks.py (right):

http://codereview.chromium.org/1191002/diff/2001/3004#newcode117
chrome/test/functional/bookmarks.py:117: def _GetTestURLs(self, filename):
On 2010/03/24 00:21:12, John Grabowski wrote:
> Have this function prefix the DataDir() for you.

Done.

http://codereview.chromium.org/1191002/diff/2001/3004#newcode120
chrome/test/functional/bookmarks.py:120: dictionary = eval(contents,
{'__builtins__': None}, None)
On 2010/03/24 00:21:12, John Grabowski wrote:
> Add try around this to catch eval error; sometimes eval errors can be cryptic
> and you want to be sure to print out the failed filename.
> 

Done.

http://codereview.chromium.org/1191002/diff/2001/3001
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/1191002/diff/2001/3001#newcode134
chrome/test/pyautolib/pyauto.py:134: """Returns the path the data dir
chorme/test/data."""
On 2010/03/24 00:21:12, John Grabowski wrote:
> chorme --> chrome
> 

Done.

[John Grabowski, 2010-03-24 00:54:06]

LGTM