Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 119092: Add git ignore file to repo. (Closed)

Created:
11 years, 6 months ago by jeremy
Modified:
9 years, 6 months ago
Reviewers:
tony, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add git ignore file to repo. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17540

Patch Set 1 #

Patch Set 2 : updates from Evan's copy #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A .gitignore View 1 1 chunk +34 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
jeremy
11 years, 6 months ago (2009-06-03 18:29:50 UTC) #1
Evan Martin
Here's mine. I think this can be improved over time, so my only comment is ...
11 years, 6 months ago (2009-06-03 18:30:45 UTC) #2
jeremy
Ready for another look...
11 years, 6 months ago (2009-06-03 18:39:37 UTC) #3
Evan Martin
LGTM
11 years, 6 months ago (2009-06-03 19:26:44 UTC) #4
tony
11 years, 6 months ago (2009-06-03 20:19:30 UTC) #5
http://codereview.chromium.org/119092/diff/2001/3001
File .gitignore (right):

http://codereview.chromium.org/119092/diff/2001/3001#newcode33
Line 33: /webkit/data/
Isn't this where we keep our layout test results?  I think you want:
webkit/data/layout_tests/LayoutTests

It would also be nice to have /out/ which is the make output directory.

Also, this list doesn't seem to include all the src-internal repositories, but
maybe that's not a big deal?

Powered by Google App Engine
This is Rietveld 408576698