Issue 119082: Declare register names as static constants rather than external globals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119082: Declare register names as static constants rather than external globals. (Closed)

Created:
11 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Declare register names as static constants rather than external globals. Committed: http://code.google.com/p/v8/source/detail?r=2102

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -40 lines)			Patch
	M	src/ia32/assembler-ia32.h	View	1	2 chunks	+17 lines, -17 lines	2 comments	Download
	M	src/ia32/assembler-ia32.cc	View	1	1 chunk	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

William Hesse

On 2009/06/03 15:30:41, Kevin Millikin wrote: > Why static? I think it makes them local ...

11 years, 6 months ago (2009-06-04 10:24:34 UTC) #3

William Hesse

http://codereview.chromium.org/119082/diff/7/9 File src/ia32/assembler-ia32.h (right): http://codereview.chromium.org/119082/diff/7/9#newcode103 Line 103: const XMMRegister xmm0 = { 0 }; OK, ...

11 years, 6 months ago (2009-06-04 10:49:51 UTC) #4

Kevin Millikin (Chromium)

11 years, 6 months ago (2009-06-04 10:58:31 UTC) #5

OK then, LGTM.

http://codereview.chromium.org/119082/diff/7/9
File src/ia32/assembler-ia32.h (right):

http://codereview.chromium.org/119082/diff/7/9#newcode82
Line 82: const Register eax = {0};
Format this one like the others.

Expand Messages | Collapse Messages