Make tickprocessor's ProfileView extensible and move out DevTools-only stuff.

tools/profile_view.js

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 35 matching lines @@
  * Builds a profile view for the specified call tree.
  *
  * @param {devtools.profiler.CallTree} callTree A call tree.
  * @param {boolean} opt_bottomUpViewWeights Whether remapping
  *     of self weights for a bottom up view is needed.
  */
 devtools.profiler.ViewBuilder.prototype.buildView = function(
     callTree, opt_bottomUpViewWeights) {
   var head;
   var samplingRate = this.samplingRate;
+  var createViewNode = this.createViewNode;
   callTree.traverse(function(node, viewParent) {
     var totalWeight = node.totalWeight * samplingRate;
     var selfWeight = node.selfWeight * samplingRate;
     if (opt_bottomUpViewWeights === true) {
       if (viewParent === head) {
         selfWeight = totalWeight;
       } else {
         selfWeight = 0;
       }
     }
-    var viewNode = new devtools.profiler.ProfileView.Node(
-        node.label, totalWeight, selfWeight, head);
+    var viewNode = createViewNode(node.label, totalWeight, selfWeight, head);
     if (viewParent) {
       viewParent.addChild(viewNode);
     } else {
       head = viewNode;
     }
     return viewNode;
   });
-  var view = new devtools.profiler.ProfileView(head);
+  var view = this.createView(head);
   return view;
 };
 
 
 /**
+ * Factory method for a profile view.
+ *
+ * @param {devtools.profiler.ProfileView.Node} head View head node.
+ * @return {devtools.profiler.ProfileView} Profile view.
+ */
+devtools.profiler.ViewBuilder.prototype.createView = function(head) {
+  return new devtools.profiler.ProfileView(head);
+};
+
+
+/**
+ * Factory method for a profile view node.
+ *
+ * @param {string} internalFuncName A fully qualified function name.
+ * @param {number} totalTime Amount of time that application spent in the
+ *     corresponding function and its descendants (not that depending on
+ *     profile they can be either callees or callers.)
+ * @param {number} selfTime Amount of time that application spent in the
+ *     corresponding function only.
+ * @param {devtools.profiler.ProfileView.Node} head Profile view head.
+ * @return {devtools.profiler.ProfileView.Node} Profile view node.
+ */
+devtools.profiler.ViewBuilder.prototype.createViewNode = function(
+    funcName, totalTime, selfTime, head) {
+  return new devtools.profiler.ProfileView.Node(
+      funcName, totalTime, selfTime, head);
+};
+
+
+/**
  * Creates a Profile View object. It allows to perform sorting
  * and filtering actions on the profile. Profile View mimicks
  * the Profile object from WebKit's JSC profiler.
  *
  * @param {devtools.profiler.ProfileView.Node} head Head (root) node.
  * @constructor
  */
 devtools.profiler.ProfileView = function(head) {
   this.head = head;
   this.title = '';
@@ skipping 42 matching lines @@
  * @param {number} totalTime Amount of time that application spent in the
  *     corresponding function and its descendants (not that depending on
  *     profile they can be either callees or callers.)
  * @param {number} selfTime Amount of time that application spent in the
  *     corresponding function only.
  * @param {devtools.profiler.ProfileView.Node} head Profile view head.
  * @constructor
  */
 devtools.profiler.ProfileView.Node = function(
     internalFuncName, totalTime, selfTime, head) {
-  this.callIdentifier = 0;
   this.internalFuncName = internalFuncName;
-  this.initFuncInfo();
   this.totalTime = totalTime;
   this.selfTime = selfTime;
   this.head = head;
   this.parent = null;
   this.children = [];
-  this.visible = true;
 };
 
 
-/**
- * RegEx for stripping V8's prefixes of compiled functions.
- */
-devtools.profiler.ProfileView.Node.FUNC_NAME_STRIP_RE =
-    /^(?:LazyCompile|Function): (.*)$/;
-
-
-/**
- * RegEx for extracting script source URL and line number.
- */
-devtools.profiler.ProfileView.Node.FUNC_NAME_PARSE_RE = /^([^ ]+) (.*):(\d+)$/;
-
-
-/**
- * RegEx for removing protocol name from URL.
- */
-devtools.profiler.ProfileView.Node.URL_PARSE_RE = /^(?:http:\/)?.*\/([^/]+)$/;
-
-
-/**
- * Inits 'functionName', 'url', and 'lineNumber' fields using 'internalFuncName'
- * field.
- */
-devtools.profiler.ProfileView.Node.prototype.initFuncInfo = function() {
-  var nodeAlias = devtools.profiler.ProfileView.Node;
-  this.functionName = this.internalFuncName;
-
-  var strippedName = nodeAlias.FUNC_NAME_STRIP_RE.exec(this.functionName);
-  if (strippedName) {
-    this.functionName = strippedName[1];
-  }
-
-  var parsedName = nodeAlias.FUNC_NAME_PARSE_RE.exec(this.functionName);
-  if (parsedName) {
-    this.url = parsedName[2];
-    var parsedUrl = nodeAlias.URL_PARSE_RE.exec(this.url);
-    if (parsedUrl) {
-      this.url = parsedUrl[1];
-    }
-    this.functionName = parsedName[1];
-    this.lineNumber = parsedName[3];
-  } else {
-    this.url = '';
-    this.lineNumber = 0;
-  }
-};
-
-
 /**
  * Returns a share of the function's total time in application's total time.
  */
 devtools.profiler.ProfileView.Node.prototype.__defineGetter__(
     'totalPercent',
     function() { return this.totalTime /
       (this.head ? this.head.totalTime : this.totalTime) * 100.0; });
 
 
 /**
@@ skipping 29 matching lines @@
  * Sorts all the node's children recursively.
  *
  * @param {function(devtools.profiler.ProfileView.Node,
  *     devtools.profiler.ProfileView.Node):number} sortFunc A sorting
  *     functions. Must comply with Array.sort sorting function requirements.
  */
 devtools.profiler.ProfileView.Node.prototype.sortChildren = function(
     sortFunc) {
   this.children.sort(sortFunc);
 };