Issue 119068: For connection-based authentication schemes such as NTLM,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119068: For connection-based authentication schemes such as NTLM,... (Closed)

Created:
11 years, 6 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

For connection-based authentication schemes such as NTLM, we keep the connection alive even if the server or proxy tells us to close it. R=eroman BUG=http://crbug.com/8771 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17673

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : Upload before checkin #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -41 lines)			Patch
	M	net/http/http_network_transaction.cc	View	1	4 chunks	+13 lines, -41 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

This is an experimental change to see if it will fix the Squid NTLM auth ...

11 years, 6 months ago (2009-06-03 02:06:56 UTC) #1

eroman

11 years, 6 months ago (2009-06-03 03:19:10 UTC) #2

lgtm

http://codereview.chromium.org/119068/diff/1/2
File net/http/http_network_transaction.cc (right):

http://codereview.chromium.org/119068/diff/1/2#newcode245
Line 245: // marks the connection as not keep-alive, we still keep it alive.
nit: "not keep-alive" --> "non keep-alive" ?

Expand Messages | Collapse Messages