Issue 119061: Convert to gyp generation of chrome_resources and chrome_strings....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119061: Convert to gyp generation of chrome_resources and chrome_strings.... (Closed)

Created:
11 years, 6 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Convert to gyp generation of chrome_resources and chrome_strings. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17467

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -65 lines)			Patch
M	chrome/app/chrome_dll.vcproj	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/app/locales/locales.gyp	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/app/theme/theme_dll.vcproj	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser.vcproj	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View		16 chunks	+36 lines, -38 lines	0 comments	Download
M	chrome/test/browser/browser_tests_dll.vcproj	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/test/interactive_ui/interactive_ui.vcproj	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/test/unit/unittests.vcproj	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/tools/build/win/language_dll.vsprops	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/grit/build/grit_localized_resources.rules	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/grit/build/grit_resources.rules	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/grit/build/using_generated_resources.vsprops	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sgk

Please double-check this one (I'm currently waiting on preliminary trybot results.)

11 years, 6 months ago (2009-06-02 22:47:09 UTC) #1

bradn

11 years, 6 months ago (2009-06-02 22:49:48 UTC) #2

LGTM

http://codereview.chromium.org/119061/diff/1/8
File chrome/app/locales/locales.gyp (right):

http://codereview.chromium.org/119061/diff/1/8#newcode4
Line 4: # Switch to with chrome.sln landing.
You can drop this comment now.

Expand Messages | Collapse Messages