Add functions to glue to get the full html of the page and also to check if t...

Add functions to glue to get the full html of the page and also to check if the user has selected something.
This is for enhanced printing support (in progress).



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17427

[Sverrir, 2009-06-02 16:10:22]

Prepare print selection, also added a function that gets the full html of the
page that works much better than selectall/gethtml (not sure this will be what
we use in the end though).

[M-A Ruel, 2009-06-02 16:15:09]

http://codereview.chromium.org/119043/diff/1/3
File webkit/glue/webframe.h (right):

http://codereview.chromium.org/119043/diff/1/3#newcode329
Line 329: // Checks if there is currently a selected area (indicates that
GetSelection
Is this function a performance optimization? I don't see it's advantage against
simply calling !GetSelection(true).empty()

http://codereview.chromium.org/119043/diff/1/2
File webkit/glue/webframe_impl.cc (right):

http://codereview.chromium.org/119043/diff/1/2#newcode1421
Line 1421: return (frame()->selection()->start() !=
Why the test here is different that the one in GetSelection?

[Sverrir, 2009-06-02 17:19:03]

Commments below.

On 2009/06/02 16:15:09, M-A wrote:
> http://codereview.chromium.org/119043/diff/1/3
> File webkit/glue/webframe.h (right):
> 
> http://codereview.chromium.org/119043/diff/1/3#newcode329
> Line 329: // Checks if there is currently a selected area (indicates that
> GetSelection
> Is this function a performance optimization? I don't see it's advantage
against
> simply calling !GetSelection(true).empty()
> 
> http://codereview.chromium.org/119043/diff/1/2
> File webkit/glue/webframe_impl.cc (right):
> 
> http://codereview.chromium.org/119043/diff/1/2#newcode1421
> Line 1421: return (frame()->selection()->start() !=
> Why the test here is different that the one in GetSelection?

[Sverrir, 2009-06-02 17:19:58]

Comments below (now)

http://codereview.chromium.org/119043/diff/1/3
File webkit/glue/webframe.h (right):

http://codereview.chromium.org/119043/diff/1/3#newcode329
Line 329: // Checks if there is currently a selected area (indicates that
GetSelection
Sort of.  I'm not sure there is a defined contract for what GetSelection returns
if there is no selection - and that could change for all that I know.

On 2009/06/02 16:15:09, M-A wrote:
> Is this function a performance optimization? I don't see it's advantage
against
> simply calling !GetSelection(true).empty()

http://codereview.chromium.org/119043/diff/1/2
File webkit/glue/webframe_impl.cc (right):

http://codereview.chromium.org/119043/diff/1/2#newcode1421
Line 1421: return (frame()->selection()->start() !=
Even when there is no selection the range is non-null.  I should possibly change
the GetSelection method to use HasSelection instead?

On 2009/06/02 16:15:09, M-A wrote:
> Why the test here is different that the one in GetSelection?

[M-A Ruel, 2009-06-02 18:27:40]

lgtm even if I still doubt adding a function is necessary.

http://codereview.chromium.org/119043/diff/1/3
File webkit/glue/webframe.h (right):

http://codereview.chromium.org/119043/diff/1/3#newcode329
Line 329: // Checks if there is currently a selected area (indicates that
GetSelection
On 2009/06/02 17:19:58, Sverrir wrote:
> Sort of.  I'm not sure there is a defined contract for what GetSelection
returns
> if there is no selection - and that could change for all that I know.

There's only one user of GetSelection(false) and no user of GetSelection(true).
I guess I'm missing something since AFAIK Ctrl-C works so there must be
something I'm missing here.

http://codereview.chromium.org/119043/diff/1/2
File webkit/glue/webframe_impl.cc (right):

http://codereview.chromium.org/119043/diff/1/2#newcode1421
Line 1421: return (frame()->selection()->start() !=
On 2009/06/02 17:19:58, Sverrir wrote:
> Even when there is no selection the range is non-null.  I should possibly
change
> the GetSelection method to use HasSelection instead?

I guess it's fine. GetSelection() wants to return an empty string when nothing
is selected. As long as it's happening, it's fine.