Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 119039: DevTools Profiler: use sampling rate reported by V8 profiler.... (Closed)

Created:
11 years, 6 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

DevTools Profiler: use sampling rate reported by V8 profiler. Also fix a small problem with displaying "Processing..." icon: handle the case when log processing finishes prior to 'didIsProfilingStarted_' arrived. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M webkit/glue/devtools/js/debugger_agent.js View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/devtools/js/profiler_processor.js View 5 chunks +28 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
11 years, 6 months ago (2009-06-02 12:54:47 UTC) #1
pfeldman
11 years, 6 months ago (2009-06-02 13:03:54 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698