Add ability to theme our buttons....

chrome/common/extensions/extension.cc

Index: chrome/common/extensions/extension.cc
===================================================================
--- chrome/common/extensions/extension.cc	(revision 17327)
+++ chrome/common/extensions/extension.cc	(working copy)
@@ -542,14 +542,27 @@
         std::string val;
         int color = 0;
         ListValue* color_list;
-        if (!colors_value->GetList(*iter, &color_list) ||
-            color_list->GetSize() != 3 ||
-            !color_list->GetInteger(0, &color) ||
-            !color_list->GetInteger(1, &color) ||
-            !color_list->GetInteger(2, &color)) {
-          *error = kInvalidThemeColorsError;
-          return false;
+        if (colors_value->GetList(*iter, &color_list)) {
+          if (color_list->GetSize() == 3 ||

[Ben Goodger (Google), 2009/06/03 18:03:57]

btw, this function has become so long its stupid. It's no longer clear from a
glance at one screenful what it even does.

+              color_list->GetSize() == 4) {
+            if (color_list->GetInteger(0, &color) &&
+                color_list->GetInteger(1, &color) &&
+                color_list->GetInteger(2, &color)) {
+              if (color_list->GetSize() == 4) {
+                double alpha;
+                if (color_list->GetReal(3, &alpha)) {
+                  ++iter;
+                  continue;
+                }
+              } else {
+                ++iter;
+                continue;
+              }
+            }
+          }
         }
+        *error = kInvalidThemeColorsError;
+        return false;
         ++iter;
       }
       theme_colors_.reset(