Add ability to theme our buttons....

chrome/common/extensions/extension.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include "app/resource_bundle.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
@@ skipping 524 matching lines @@
     }
 
     DictionaryValue* colors_value;
     if (theme_value->GetDictionary(kThemeColorsKey, &colors_value)) {
       // Validate that the colors are all three-item lists
       DictionaryValue::key_iterator iter = colors_value->begin_keys();
       while (iter != colors_value->end_keys()) {
         std::string val;
         int color = 0;
         ListValue* color_list;
-        if (!colors_value->GetList(*iter, &color_list) ||
-            color_list->GetSize() != 3 ||
-            !color_list->GetInteger(0, &color) ||
-            !color_list->GetInteger(1, &color) ||
-            !color_list->GetInteger(2, &color)) {
-          *error = kInvalidThemeColorsError;
-          return false;
+        if (colors_value->GetList(*iter, &color_list)) {
+          if (color_list->GetSize() == 3 ||

[Ben Goodger (Google), 2009/06/03 18:03:57]

btw, this function has become so long its stupid. It's no longer clear from a
glance at one screenful what it even does.

+              color_list->GetSize() == 4) {
+            if (color_list->GetInteger(0, &color) &&
+                color_list->GetInteger(1, &color) &&
+                color_list->GetInteger(2, &color)) {
+              if (color_list->GetSize() == 4) {
+                double alpha;
+                if (color_list->GetReal(3, &alpha)) {
+                  ++iter;
+                  continue;
+                }
+              } else {
+                ++iter;
+                continue;
+              }
+            }
+          }
         }
+        *error = kInvalidThemeColorsError;
+        return false;
         ++iter;
       }
       theme_colors_.reset(
           static_cast<DictionaryValue*>(colors_value->DeepCopy()));
     }
 
     DictionaryValue* tints_value;
     if (theme_value->GetDictionary(kThemeTintsKey, &tints_value)) {
       // Validate that the tints are all reals.
       DictionaryValue::key_iterator iter = tints_value->begin_keys();
@@ skipping 140 matching lines @@
             kInvalidPermissionSchemeError, IntToString(i));
         return false;
       }
 
       permissions_.push_back(pattern);
     }
   }
 
   return true;
 }