Issue 119025: Add ability to theme our buttons....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119025: Add ability to theme our buttons.... (Closed)

Created:
11 years, 6 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add ability to theme our buttons. BUG=12762 TEST=Verify that buttons can be themed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17586

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+206 lines, -85 lines)			Patch
A	chrome/app/theme/back_mask.png	View	Binary file		0 comments	Download
A	chrome/app/theme/button_mask.png	View	Binary file		0 comments	Download
A	chrome/app/theme/forward_mask.png	View	Binary file		0 comments	Download
A	chrome/app/theme/go_mask.png	View	Binary file		0 comments	Download
M	chrome/app/theme/notused.png	View	Binary file		0 comments	Download
A	chrome/app/theme/star_mask.png	View	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/browser_theme_provider.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_theme_provider.cc	View	6 chunks	+65 lines, -61 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.cc	View	3 chunks	+28 lines, -10 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 chunk	+20 lines, -7 lines	1 comment	Download
M	skia/ext/image_operations.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	skia/ext/image_operations.cc	View	1 chunk	+53 lines, -0 lines	0 comments	Download
M	views/controls/button/image_button.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	views/controls/button/image_button.cc	View	3 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

Includes some minor cleanups in browser_theme_provider and toolbar_view.

11 years, 6 months ago (2009-06-02 06:19:33 UTC) #1

Ben Goodger (Google)

11 years, 6 months ago (2009-06-03 18:03:56 UTC) #2

OK

http://codereview.chromium.org/119025/diff/2001/3015
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/119025/diff/2001/3015#newcode546
Line 546: if (color_list->GetSize() == 3 ||
btw, this function has become so long its stupid. It's no longer clear from a
glance at one screenful what it even does.

Expand Messages | Collapse Messages