Issue 119021: Switching chrome.sln to gyp generated version....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119021: Switching chrome.sln to gyp generated version.... (Closed)

Created:
11 years, 6 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Switching chrome.sln to gyp generated version. Doing this by using existing vcproj files. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17379

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -3311 lines)			Patch
M	build/all.gyp	View	1 2 3 4	2 chunks	+1 line, -5 lines	1 comment	Download
M	chrome/chrome.gyp	View	1 2 3 4	40 chunks	+91 lines, -0 lines	1 comment	Download
D	chrome/chrome.sln	View	1 2 3 4	1 chunk	+0 lines, -3306 lines	0 comments	Download
M	chrome/installer/installer.gyp	View	1 2 3 4	9 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/third_party/hunspell/hunspell.gyp	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

Gonna submit this TBR as it passes on the trybots and I'm curious to see ...

11 years, 6 months ago (2009-06-02 03:24:01 UTC) #1

sgk

11 years, 6 months ago (2009-06-02 07:33:47 UTC) #2

http://codereview.chromium.org/119021/diff/29/1006
File build/all.gyp (right):

http://codereview.chromium.org/119021/diff/29/1006#newcode7
Line 7: 'conditions': [
This whole condition should be deleted, because we're no longer using the
all_gyps variable.

http://codereview.chromium.org/119021/diff/29/1010
File chrome/chrome.gyp (right):

http://codereview.chromium.org/119021/diff/29/1010#newcode3629
Line 3629: 'target_name': 'browser_views',
This fits a little more naturally up underneath 'browser'.  I'll move it as part
of finishing the port of 'browser_views' to all of the platforms.

Expand Messages | Collapse Messages