Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 119014: Add some browser-level checks to prohibit access to extension bindings by... (Closed)

Created:
11 years, 6 months ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add some browser-level checks to prohibit access to extension bindings by non-extension renderers. Also add a check so that bindings are only exposed if the top-level frame is the chrome-extension scheme. BUG=11545 BUG=11993 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17408

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -10 lines) Patch
M chrome/browser/child_process_security_policy.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/child_process_security_policy.cc View 8 chunks +33 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/port/bindings/v8/v8_proxy.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Matt Perry
11 years, 6 months ago (2009-06-01 23:17:11 UTC) #1
Aaron Boodman
11 years, 6 months ago (2009-06-02 18:11:12 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698