Update CheckChangeSvnEolStyle() to be upload-friendly.

presubmit_canned_checks.py

 #!/usr/bin/env python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 ### Description checks
 
@@ skipping 160 matching lines @@
     return [output_api.PresubmitPromptWarning(msg, items=bad)]
   else:
     return []
 
 
 def CheckChangeSvnEolStyle(input_api, output_api, source_file_filter=None):
   """Checks that the source files have svn:eol-style=LF."""
   bad = filter(lambda f: f.scm == 'svn' and f.Property('svn:eol-style') != 'LF',
                input_api.AffectedSourceFiles(source_file_filter))
   if bad:
-    return [output_api.PresubmitError(
-          "Fix these files with svn svn:eol-style=LF", items=bad)]
+    if input_api.is_committing:
+      return [output_api.PresubmitError(
+            "Fix these files with svn svn:eol-style=LF", items=bad)]
+    else:
+      return [output_api.PresubmitNotifyResult(
+            "Fix these files with svn svn:eol-style=LF", items=bad)]
   return []
 
 
 ### Other checks
 
 def CheckDoNotSubmit(input_api, output_api):
   return (
       CheckDoNotSubmitInDescription(input_api, output_api) +
       CheckDoNotSubmitInFiles(input_api, output_api)
       )
@@ skipping 41 matching lines @@
                                   long_text=input_api.traceback.format_exc()))
 
   buffer = input_api.cStringIO.StringIO()
   results = input_api.unittest.TextTestRunner(stream=buffer, verbosity=0).run(
       input_api.unittest.TestSuite(tests_suite))
   if not results.wasSuccessful():
     outputs.append(message_type("%d unit tests failed." %
                                 (len(results.failures) + len(results.errors)),
                                 long_text=buffer.getvalue()))
   return outputs