tests/gcl_unittest.py - Issue 118498: Make the presubmit output much more compact.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gcl_unittest.py

Issue 118498: Make the presubmit output much more compact. (Closed)

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/gcl_unittest.py

diff --git a/tests/gcl_unittest.py b/tests/gcl_unittest.py

index 674b68cc9cf7a0ba55ed136c58fe4202a23214de..1c07de8a61fdbebde6386e503c8835fd507c9374 100755

--- a/tests/gcl_unittest.py

+++ b/tests/gcl_unittest.py

@@ -184,7 +184,7 @@ class UploadCLUnittest(GclTestsBase):

self.mox.StubOutWithMock(change_info, 'Save')

args = ['--foo=bar']

change_info.Save()

- gcl.DoPresubmitChecks(change_info, committing=False).AndReturn(True)

+ gcl.DoPresubmitChecks(change_info, False, True).AndReturn(True)

gcl.GetCodeReviewSetting('CODE_REVIEW_SERVER').AndReturn('my_server')

gcl.os.getcwd().AndReturn('somewhere')

gcl.os.chdir(gcl.GetRepositoryRoot().AndReturn(None))

@@ -205,7 +205,7 @@ class UploadCLUnittest(GclTestsBase):

change_info.Save = self.mox.CreateMockAnything()

args = ['--server=a']

change_info.Save()

- gcl.DoPresubmitChecks(change_info, committing=False).AndReturn(True)

+ gcl.DoPresubmitChecks(change_info, False, True).AndReturn(True)

gcl.GetCodeReviewSetting('CODE_REVIEW_SERVER').AndReturn('my_server')

gcl.tempfile.mkstemp(text=True).AndReturn((42, 'descfile'))

gcl.os.write(42, change_info.description)

@@ -229,7 +229,7 @@ class UploadCLUnittest(GclTestsBase):

change_info.Save = self.mox.CreateMockAnything()

args = ['--no-try']

change_info.Save()

- gcl.DoPresubmitChecks(change_info, committing=False).AndReturn(True)

+ gcl.DoPresubmitChecks(change_info, False, True).AndReturn(True)

gcl.GetCodeReviewSetting('CODE_REVIEW_SERVER').AndReturn('my_server')

gcl.tempfile.mkstemp(text=True).AndReturn((42, 'descfile'))

gcl.os.write(42, change_info.description)

@@ -253,7 +253,7 @@ class UploadCLUnittest(GclTestsBase):

self.mox.StubOutWithMock(change_info, 'Save')

args = []

change_info.Save()

- gcl.DoPresubmitChecks(change_info, committing=False).AndReturn(True)

+ gcl.DoPresubmitChecks(change_info, False, True).AndReturn(True)

gcl.GetCodeReviewSetting('CODE_REVIEW_SERVER').AndReturn('my_server')

gcl.tempfile.mkstemp(text=True).AndReturn((42, 'descfile'))

gcl.os.write(42, change_info.description)

« no previous file with comments | « presubmit_support.py ('k') | tests/presubmit_unittest.py » ('j') | no next file with comments »