chrome/browser/icon_manager_mac.mm - Issue 118488: Add file icons to chrome://downloads/ on the Mac. Add Skia helper CGImageToSkBitmap().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/icon_manager_mac.mm

Issue 118488: Add file icons to chrome://downloads/ on the Mac. Add Skia helper CGImageToSkBitmap(). (Closed)

Patch Set: Switch to using |-drawInRect:| rather than |-drawAtPoint:| Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/icon_manager_mac.mm

diff --git a/chrome/browser/icon_manager_mac.mm b/chrome/browser/icon_manager_mac.mm

index 3e5d8bed6ec936a87336cf1a07ab67817fd4fea3..9f13218c3683dece49265edbb8edeb0e2d70a1b4 100644

--- a/chrome/browser/icon_manager_mac.mm

+++ b/chrome/browser/icon_manager_mac.mm

@@ -5,8 +5,8 @@

#include "chrome/browser/icon_manager.h"

#include "base/file_path.h"

+#include "base/sys_string_conversions.h"

IconGroupID IconManager::GetGroupIDFromFilepath(const FilePath& filepath) {

- NOTIMPLEMENTED();

- return std::string();

+ return filepath.Extension();

}

« no previous file with comments | « chrome/browser/icon_loader_mac.mm ('k') | skia/ext/skia_utils_mac.h » ('j') | no next file with comments »