Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 118484: Use input_api.ReadFile() instead of rolling out its own. (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use input_api.ReadFile() instead of rolling out its own. TEST=none BUG=none

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -33 lines) Patch
M PRESUBMIT.py View 2 chunks +1 line, -13 lines 0 comments Download
M PRESUBMIT_unittest.py View 1 4 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
11 years, 6 months ago (2009-06-10 01:10:42 UTC) #1
Nicolas Sylvain
11 years, 6 months ago (2009-06-10 02:00:35 UTC) #2
LGTM - mostly rubber stamped

Powered by Google App Engine
This is Rietveld 408576698