Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: skia/ext/image_operations.cc

Issue 118456: Fix a unit test failure. One of the tests sends an empty bitmap through this... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/image_operations.cc
===================================================================
--- skia/ext/image_operations.cc (revision 17971)
+++ skia/ext/image_operations.cc (working copy)
@@ -626,8 +626,6 @@
// static
SkBitmap ImageOperations::DownsampleByTwo(const SkBitmap& bitmap) {
- DCHECK(bitmap.getConfig() == SkBitmap::kARGB_8888_Config);
Peter Kasting 2009/06/09 21:10:46 Instead of removing this, the right fix seems like
-
// Handle the nop case.
if (bitmap.width() <= 1 || bitmap.height() <= 1)
return bitmap;
@@ -678,7 +676,7 @@
ag += (tmp >> 8) & 0xFF00FF;
rb += tmp & 0xFF00FF;
- // PUt the channels back together, dividing each by 4 to get the average.
+ // Put the channels back together, dividing each by 4 to get the average.
// |ag| has the alpha and green channels shifted right by 8 bits from
// there they should end up, so shifting left by 6 gives them in the
// correct position divided by 4.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698