Issue 118455: Binary File download issue (FTP)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118455: Binary File download issue (FTP) (Closed)

Created:
11 years, 6 months ago by ibrar

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

[This CL has been replaced by http://codereview.chromium.org/118459 ] BUG=4965 R=wtc Description: Binary file download issue (pointed by TC) fixed

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	net/ftp/ftp_network_transaction.cc	View		4 chunks	+9 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

11 years, 6 months ago (2009-06-09 21:36:32 UTC) #3

http://codereview.chromium.org/118455/diff/1/2
File net/ftp/ftp_network_transaction.cc (right):

http://codereview.chromium.org/118455/diff/1/2#newcode707
Line 707: case ERROR_CLASS_ERROR:
Our convention is to not use 'else' after 'return'.
I will rewrite this if-else as:

  if (retr_failed_)
    return Stop(ERR_FAILED);
  retr_failed_ = true;

Expand Messages | Collapse Messages