Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 118452: For lack of a better approach we now initiate the plugin src url download in ... (Closed)

Created:
11 years, 6 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

For lack of a better approach we now initiate the plugin src url download in a delayed task as the Flash plugin hangs if it starts receiving data before receiving valid plugin geometry. This fixes bug http://code.google.com/p/chromium/issues/detail?id=12993 Bug=12993 TEST=Navigate to google.com/finance and open the tickers in background tabs. They should not cause the browser to hang. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18033

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M webkit/glue/webplugin_impl.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/glue/webplugin_impl.cc View 1 2 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
11 years, 6 months ago (2009-06-09 20:35:42 UTC) #1
jam
11 years, 6 months ago (2009-06-10 03:12:24 UTC) #2
lgtm, sorry for the detours

http://codereview.chromium.org/118452/diff/1/3
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/118452/diff/1/3#newcode681
Line 681: MessageLoop::current()->PostDelayedTask(FROM_HERE,
please add a comment here explaining why we're doing this

Powered by Google App Engine
This is Rietveld 408576698