Issue 118452: For lack of a better approach we now initiate the plugin src url download in ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118452: For lack of a better approach we now initiate the plugin src url download in ... (Closed)

Created:
11 years, 6 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

For lack of a better approach we now initiate the plugin src url download in a delayed task as the Flash plugin hangs if it starts receiving data before receiving valid plugin geometry. This fixes bug http://code.google.com/p/chromium/issues/detail?id=12993 Bug=12993 TEST=Navigate to google.com/finance and open the tickers in background tabs. They should not cause the browser to hang. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18033

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	webkit/glue/webplugin_impl.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
	M	webkit/glue/webplugin_impl.cc	View	1	2 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

11 years, 6 months ago (2009-06-10 03:12:24 UTC) #2

lgtm, sorry for the detours

http://codereview.chromium.org/118452/diff/1/3
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/118452/diff/1/3#newcode681
Line 681: MessageLoop::current()->PostDelayedTask(FROM_HERE,
please add a comment here explaining why we're doing this

Expand Messages | Collapse Messages